-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api,ui): use feedFullName as id for data-feeds #66
Conversation
I have the hunch that we may want to add the number of decimal digits in the |
Then, the data-feed-explorer would show two different feeds for the same one. From now on, we have this information in the contract so we can store it in |
I mean, in that case we would definitely want to list 2 different feeds on the site. |
bd09e30
to
aa95f43
Compare
36a2639
to
209fa0e
Compare
a226592
to
c6c1baa
Compare
docker-compose.yml
Outdated
ETHEREUM_MAINNET_PROVIDER: $ETHEREUM_MAINNET_PROVIDER | ||
ETHEREUM_GOERLI_PROVIDER: $ETHEREUM_GOERLI_PROVIDER | ||
ETHEREUM_KOVAN_PROVIDER: $ETHEREUM_KOVAN_PROVIDER | ||
ETHEREUM_RINKEBY_PROVIDER: $ETHEREUM_RINKEBY_PROVIDER | ||
CONFLUX_TESTNET_PROVIDER: $CONFLUX_TESTNET_PROVIDER | ||
CONFLUX_MAINNET_PROVIDER: $CONFLUX_MAINNET_PROVIDER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't afford having to specify providers here. This should proably be on each feed's configuration or whatever, as in an ideal world, we should be able to add feeds without doing PRs, simply by modifying config files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are adding it in this way because we are using providers with secrets instead of the Portainer's gateway. In other PR, we can avoid modifying this file and the provider's dictionary every time we want to support a new network.
Update
feed
andresult-requests
collections adding a new field (feedFullName) to avoid use random generated id.To achieve this, the following changes have been made to
feed
andresult-requests
:feed
feedFullName
field has been addedrequest
field has been removedresult-requests
feedFullName
field has been addedfeedId
field has been removedlabel
field has been removedaddress
field has been removedModels before the migration are:
Models after the migration were:
In addtion, this PR renames network names to discern between different chains and their networks
Close #62