Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve seo #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve seo #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc22173
feat(ui): improve seo
gabaldon Aug 1, 2022
abc5584
feat(ui): implement skip to content btn
gabaldon Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Hero.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<SectionLayout class="main-section">
<SectionLayout id="main" class="main-section">
<div class="info">
<i18n path="hero.title.main" class="title header-1" tag="h1">
<span class="gradient">{{ $t('hero.title.gradient') }}</span>
Expand Down
45 changes: 37 additions & 8 deletions components/NavBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
<template>
<div class="nav-container" :class="{ drop: isMenuVisible }">
<a class="skip-to-content-link" href="#main">Skip to content</a>
<nav class="navbar" :class="{ open: isMenuVisible }">
<div class="menu-container">
<img
class="logo"
src="@/assets/images/witnet_logo.svg"
alt=""
aria-hidden="true"
/>
<label class="responsive-menu" @click="toggleMenu">
<nuxt-link :to="localePath('/')">
<img
class="logo"
src="@/assets/images/witnet_logo.svg"
alt=""
aria-hidden="true"
/>
</nuxt-link>
<button class="responsive-menu" @click="toggleMenu">
<a class="target-burger" :class="{ visible: isMenuVisible }">
<ul class="buns">
<li class="bun"></li>
<li class="bun"></li>
</ul>
</a>
</label>
</button>
</div>
<transition name="dropdown" class="dropdown">
<ul class="tab-container" :class="{ visible: isMenuVisible }">
Expand Down Expand Up @@ -82,13 +85,39 @@ export default {
</script>

<style scoped lang="scss">
.skip-to-content-link {
background: $aquamarine-1;
left: 50%;
padding: 4px 8px 8px 8px;
color: $white !important;
font-family: 'Avenir Next Variable W05835004', Arial, Helvetica, sans-serif;
font-weight: bolder;
position: absolute;
transform: translateY(-100%);
z-index: 100;
transition: transform 0.3s;
&:focus {
transform: translateY(0%);
}
}
.navbar {
display: flex;
justify-content: space-between;
align-items: center;
max-width: 1050px;
margin: 0 auto;
background-color: $white;
.responsive-menu,
input[type='submit'],
input[type='reset'] {
background: none;
color: inherit;
border: none;
padding: 0;
opacity: 1;
font: inherit;
cursor: pointer;
}
.logo {
height: 39px;
}
Expand Down
4 changes: 2 additions & 2 deletions components/layouts/SectionLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<div :class="fullBackground ? 'wide-section' : 'section'">
<section :class="fullBackground ? 'wide-section' : 'section'">
<div
v-if="fullBackground"
class="section"
Expand All @@ -8,7 +8,7 @@
<slot></slot>
</div>
<slot v-else></slot>
</div>
</section>
</template>

<script>
Expand Down