feat(c-bridge): force min collateral #2468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidiaz
force-pushed
the
c-bridge/force-min-collateral
branch
from
2a8be75
to
b540f8b
Compare
Tommytrg
requested changes
Jun 4, 2024
| dr_min_collateral_nanowits, | ||
| reward_collateral_ratio, | ||
| ); | ||
| log::warn!("DRO [{}]: witnessing collateral ({}) increased to mininum ({})", dro_hash, dro_prev_collateral, dr_min_collateral_nanowits); |
There was a problem hiding this comment.
Suggested change
| log::warn!("DRO [{}]: witnessing collateral ({}) increased to mininum ({})", dro_hash, dro_prev_collateral, dr_min_collateral_nanowits); | |
| log::warn!("DRO [{}]: witnessing collateral ({}) increased to minimum ({})", dro_hash, dro_prev_collateral, dr_min_collateral_nanowits); |
| @@ -310,12 +311,11 @@ fn deserialize_and_validate_dr_bytes( | |||
| match DataRequestOutput::from_pb_bytes(dr_bytes) { | |||
| Err(e) => Err(DrSenderError::Deserialization { msg: e.to_string() }), | |||
| Ok(dr_output) => { | |||
| let required_reward_collateral_ratio = | |||
| PSEUDO_CONSENSUS_CONSTANTS_WIP0022_REWARD_COLLATERAL_RATIO; | |||
| let mut dr_output = dr_output.clone(); | |||
There was a problem hiding this comment.
I think this .clone isn't necessary
Suggested change
| let mut dr_output = dr_output.clone(); | |
| let mut dr_output = dr_output; |
Tommytrg
approved these changes
Jun 4, 2024
Tommytrg
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.