loginConfirmed: updater returns false to ignore request

[migajek]

allow the request to be ignored from "retrying" when loginConfirmed's updater function returns false

[witoldsz]

Why won't you call rejectAll instead? Is is that there are some events you want to abandon and some you want to be retried? What's the case?

[migajek]

That is exactly the case. Some of the request are supposed to be retried,
others to be canceled.
29 lut 2016 14:35 "Witold Szczerba" notifications@github.com napisał(a):

In src/http-auth-interceptor.js
#127 (comment)
:

@@ -122,7 +122,10 @@
*/
retryAll: function(updater) {
for (var i = 0; i < buffer.length; ++i) {

•      retryHttpRequest(updater(buffer[i].config), buffer[i].deferred);
  

•      var _cfg = updater(buffer[i].config);
  

•      if (_cfg === false)
  

Why won't you call rejectAll instead? Is is that there are some events
you want to abandon and some you want to be retried? What's the case?

—
Reply to this email directly or view it on GitHub
https://github.com/witoldsz/angular-http-auth/pull/127/files#r54409370.

[witoldsz]

How about if (_cfg !== false) retryHttpRequest(_cfg, buffer[i].deferred); instead?
Also, it would be awesome if you could mention about this in documentation, most of users won't find this otherwise.

[migajek]

@witoldsz I've inverted the "if" statement and updated the docs. Please have a look :)