Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#52 upgrade versions and support #54

Merged
merged 17 commits into from
Apr 11, 2021
Merged

Feature/#52 upgrade versions and support #54

merged 17 commits into from
Apr 11, 2021

Conversation

picimako
Copy link
Collaborator

@picimako picimako commented Jul 25, 2020 •
edited

Changes:

  • Upgraded some library and platform versions (where I could I didn't pick the latest ones to try to avoid any compatibility issues)
  • Upgraded gradle wrapper to 6.1.1
  • Replaced org.easytesting:fest-util and org.easytesting:fest-assert-core with org.assertj:assertj-core
  • Removed hamcrest as it did not seem to be used anywhere
  • Migrated application components to Services
  • Migrated the fileTypeFactory extension point to fileType extension point
  • Added some missing @NotNull annotations
  • Removed some deprecated method calls and methods that were not called by the platform (according to IJ internal javadoc)
  • Added StoryRunnerConfigurationType as configurationTypeextension point so that IntelliJ will recognize the run config type even after the restart of IJ.
  • Also added an icon for StoryRunnerConfigurationType.
  • Removed JBehaveTemplateLoaderService and relocated Story file template to be automatically loaded by IntelliJ

Tamás Balog added 16 commits July 20, 2020 18:32
Upgrade version of IntelliJ, gradle wrapper, and some of the dependen…
1b80e7f 
…cies
Remove seemingly unused hamcrest dependency
c87966e
Replace easytesting libraries with assertj-core
c631d0d
Replace fest assertions with assertj ones in unit tests
43a50dd
Migrate application components to Services
47ab068
Migrate fileTypeFactory extension point to fileType extension point
9bc06cc
Reformat fileType extension point definition
9104694
Add applicationService definitions to plugin.xml instead of using @se…
66e6d3b 
…rvice annotation
Simplify @State annotation usage on in JBehaveSettings and stop using…
ad22b18 
… depracated API
Add missing param attribute and remove depracated method not called b…
9880559 
…y the platform
Remove unused imports
f461fcd
Remove unnecessary comments
1a5184a
Add icon to StoryRunnerConfigurationType
40e8fbf
Remove most deprecated method calls from RunStoryAction and add Story…
f58d9d4 
…RunnerConfigurationType to plugin.xml explicitly as a configurationType extension point
Change component retireval of JBehaveSettings to service retrieval in…
c9f197e 
… StoryCompletionContributor
Update comments in plugin.xml
c4e524f
@picimako picimako mentioned this pull request Jul 26, 2020
Open
@picimako
Copy link
Collaborator Author

picimako commented Aug 6, 2020 •
edited

There is still one problem, that file template import doesn't work at the moment, the plugin cannot find the .story.ft file. I'm investigating the issue but with no much luck so far.
Edit: it is solved now

@picimako picimako merged commit f65145d into witspirit:master Apr 11, 2021
@picimako picimako deleted the feature/#52-upgrade-versions-and-support branch April 11, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@picimako