Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tag is changed to picture tag #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

garybarzola
Copy link

@garybarzola garybarzola commented Oct 6, 2023

  • The picture tag is currently compatible with all browsers and allows progressive image loading according to the available internet conditions and screen sizes.

@danigandarillas
Copy link

Great, really good solution and upgrade. It will help a lot!

@ernestoliberio
Copy link

ernestoliberio commented Oct 13, 2023

This should be in the repo as a feature
@wittlock

@wittlock
Copy link
Owner

I'm not personally familiar with the picture tag and it's compatibility. It seems fairly well adapted looking at caniuse.com - but I'd be a bit worried swapping a core tag like this out just like that.
Could this maybe be adjusted to be an alternative template with an opt-in setting to use it?

@garybarzola
Copy link
Author

garybarzola commented Nov 9, 2023

Of course it works just as you describe, that's the great thing about this picture tag. I have added two alternative inputs: thumbImageSource and fullImageSource, which if added would complete the functionality of the picture tag and if not added would work as it has been working with the thumbImage and fullImage inputs.

@wittlock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants