change rule no-commit to not accept forEach cases since forEach break…

…s chains in v4
wix-incubator · Jan 25, 2016 · c28ba30 · c28ba30
1 parent 90d057c
commit c28ba30
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/docs/rules/no-commit.md b/docs/rules/no-commit.md
@@ -2,7 +2,6 @@
 
 Using `_.prototype.commit()` at the end of the chain executes the chain but doesn't unwrap the value.
 In most cases, this means that `_.prototype.value()` would be preferable. 
-However, in cases of running `forEach`, the chain could be executed only for the side effect.
 
 ## Rule Details
 
@@ -20,13 +19,11 @@ The following patterns are not considered warnings:
 
 ```js
 
-_(a).map(f).forEach(g).commit();
-
 _(a).map(f).filter(g).value();
 
 ```
 
 
 ## When Not To Use It
 
-If you do not want to disallow using `commit`, you should not use this rule.
+If you do not want to disallow using `commit`, you should not use this rule.
diff --git a/lib/rules/no-commit.js b/lib/rules/no-commit.js
@@ -1,5 +1,5 @@
 /**
- * @fileoverview Rule to disallow using _.prototype.commit unless used after a function that only runs for its side effect.
+ * @fileoverview Rule to disallow using _.prototype.commit.
  */
 'use strict';
 
@@ -17,8 +17,8 @@ module.exports = function (context) {
                 do {
                     node = node.parent.parent;
                 } while (astUtil.isMethodCall(node) && !lodashUtil.isCallToMethod(node, settings.version, 'commit'));
-                if (lodashUtil.isCallToMethod(node, settings.version, 'commit') && !lodashUtil.isCallToMethod(astUtil.getCaller(node), settings.version, 'forEach')) {
-                    context.report(node, 'Do not end chain with commit, except for side effects.');
+                if (lodashUtil.isCallToMethod(node, settings.version, 'commit')) {
+                    context.report(node, 'Do not end chain with commit.');
                 }
             }
         }

diff --git a/tests/lib/rules/no-commit.js b/tests/lib/rules/no-commit.js
@@ -12,12 +12,11 @@ var RuleTester = require('eslint').RuleTester;
 // ------------------------------------------------------------------------------
 
 var ruleTester = new RuleTester();
-var errors = [{message: 'Do not end chain with commit, except for side effects.'}];
+var errors = [{message: 'Do not end chain with commit.'}];
 ruleTester.run('prefer-map', rule, {
     valid: [
         'var x = _(a).map(f).value();',
-        '_(a).filter(f).forEach(g).value()',
-        '_(a).filter(f).forEach(g).commit()'
+        '_(a).filter(f).forEach(g);'
     ],
     invalid: [{
         code: '_(arr).map(f).commit();',