Moved the threadpool responsible for the timer tasks that kill future…

…s that time out (for .within)

This is because in an extreme load scenario, the time tasks will be queued so behind the actual threads execution tasks that they won't execute at all, causing starvation.

src/main/scala/com/wix/async/FuturePerfect.scala

@@ -3,7 +3,7 @@ package com.wix.async
 import scala.concurrent.duration.Duration
 import com.twitter.util._
 
-import java.util.concurrent.ScheduledExecutorService
+import java.util.concurrent.{Executors, ExecutorService, ScheduledExecutorService}
 import FuturePerfect._
 import Implicits._
 
@@ -14,10 +14,10 @@ import Implicits._
 
 trait FuturePerfect extends Reporting[Event] {
 
-  def executorService: ScheduledExecutorService
-  implicit lazy val timer: Timer = new ScheduledExecutorServiceTimer(executorService)
+  def executorService: ExecutorService
+  implicit lazy val timer: Timer = new ScheduledExecutorServiceTimer(Executors.newScheduledThreadPool(10))
 
-  class AsyncExecution[T](executorService: ScheduledExecutorService,
+  class AsyncExecution[T](executorService: ExecutorService,
                           timeout: Duration,
                           retryPolicy: RetryPolicy,
                           onTimeout: TimeoutHandler,

src/test/scala/com/wix/async/FuturePerfectTest.scala

@@ -183,7 +183,7 @@ class FuturePerfectTest extends SpecificationWithJUnit with Mockito with NoTimeC
   class AsyncScope extends Scope with FuturePerfect {
 
      val reporter = mock[Reporter[Event]]
-     val executorService = Executors.newScheduledThreadPool(4)
+     val executorService = Executors.newFixedThreadPool(4)
      register(reporter)
 
      class Bar {