Add execution result to Successful and ExceededTimeout events #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orrsella
added a commit
that referenced
this pull request
Feb 23, 2014
Add execution result to Successful and ExceededTimeout events
| case class ExceededTimeout(actual: Duration, executionName: String, params: Map[String, String]) extends Event | ||
| case class Successful(elapsed: Duration, executionName: String, params: Map[String, String]) extends Event | ||
| case class ExceededTimeout(actual: Duration, executionName: String, result: Any) extends Event | ||
| case class Successful(elapsed: Duration, executionName: String, result: Any) extends Event |
There was a problem hiding this comment.
This is what we discussed, right? I wouldn't go with Any here -- this will require implements to either use .asInstanceOf[T] or else pattern match on case Successful( _, _, result: T ) => .... Both are boilerplate-y and can fail at runtime. What about the "state" type solution we discussed?
|
Yes, this is what we discussed. If you care about the type of the result in the event, then you can match with the type as you said. Otherwise, you can match on I'm not sure if the current model fits the state we discussed. The Let's discuss in person. |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables additional reporting/actions to be performed based on the calculated value.