bug fix: RetrySupport ignores the delay strategy provided with RetryP…

[sha1n]

@ittaiz (or anyone else) - as the commit message says, this fixes a bug in RetrySupport, which before this fix ignores the DelayStrategy specified as a part of the RetryPolicy.

In addition to the bug fix, I would really like to make 'withRetry' a @tailrec, but in order to do that I have to make it 'final', which is a compatibility break - so if you think it's valid, I will happily do it.

[ittaiz]

@sha1n with respect to the @tailrec I don't want us to wait for it since both @dorosen and you are waiting for this fix.
Do you want to do another PR with that change only and then we'll need to see how we evaluate the risk?

[sha1n]

@ittaiz - Sure! I don't want to wait for it either. I will do it in a separate PR.
BTW, if backward compatibility is an issue, I can add a new private method, which will handle the @tailrec and leave the current as is - although it makes perfect sense to make it final.

[electricmonk]

1.10.0 release to central

-- 
http://www.shaiyallin.com

On June 17, 2015 at 11:02:13 AM, Shai Nagar (notifications@github.com) wrote:

@ittaiz - Sure! I don't want to wait for it either. I will do it in a separate PR.
BTW, if backward compatibility is an issue, I can add a new private method, which will handle the @tailrec and leave the current as is - although it makes perfect sense to make it final.

—
Reply to this email directly or view it on GitHub.