correlation is now created by first FS in chain #109
Conversation
src/memory-fs.ts
Outdated
| if (this.isIgnored(fullPath)) { | ||
| throw new Error(`Unable to save ignored path: '${fullPath}'`); | ||
| } | ||
| correlation = correlation || makeCorrelationId(); |
There was a problem hiding this comment.
isn't this better as default argument.
saveFileSync(fullPath: string, newContent: string, correlation: Correlation = makeCorrelationId()): CorrelationIt maybe not possible due to API interface, but then maybe to use other variable. After that assignment would be hard to check if there were any correlation argument at the first.
There was a problem hiding this comment.
done, made some more changes, take a look
src/local-fs.ts
Outdated
| const correlation = makeCorrelationId(); | ||
| async ensureDirectory(fullPath: string, correlation:Correlation = makeCorrelationId()): Promise<Correlation> { | ||
| this.registerCorrelationForPathsInDir(fullPath, correlation, 'directoryCreated') | ||
| // this.registerCorrelator(['directoryCreated'], correlation, e => fullPath.startsWith(e.fullPath), true); |
There was a problem hiding this comment.
thanks, any idea why the travis C keeps failing? should i ignore or explore?
There was a problem hiding this comment.
as far as i see from logs, it can't start headless chrome on linux only, so I would say ignore.
afaik it is also broken on master right now. Maybe @amir-arad knows
There was a problem hiding this comment.
sadly it's indeed broken in master. I wo'nt be around to fix it anytime soon, so as long as it fails on loading chrome, it's fine. maybe @AlexShemeshWix can have a go at it?
# Conflicts: # src/wamp-client-fs.ts # test/local-fs.spec.node.ts # test/no-feedback-events-fs.spec.ts
# Conflicts: # src/wamp-client-fs.ts # test/local-fs.spec.node.ts # test/no-feedback-events-fs.spec.ts
# Conflicts: # src/wamp-client-fs.ts # test/local-fs.spec.node.ts # test/no-feedback-events-fs.spec.ts
de-dupe local-fs events
add correlation argument to contract test
No description provided.