This repository has been archived by the owner on Nov 21, 2020. It is now read-only.
retryPromise: improve flow and avoid bad pattern #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer creates an empty Promise without any use (`async (resolve, reject)=>...`).
No longer checks and rechecks whether it's in a timout.
When timeout value is provided, it creates a single delayed rejected promise and uses it with Promise.race when doing operations.
A unique object is used to identify a timeout error. First try was `class TimeoutError extends Error {}`, but `instanceof TimeoutError` is false for IE11/Edge.
not really needed, as first run has retries equal to retriesLeft. also now avoids delaying when interval is 0.
Use do-while inside an async function
This way, avoids always creating a rejected timeout Promise, even if operation succeeded.
amir-arad
suggested changes
Oct 7, 2017
| reject(lastError); | ||
| let lastError: Error | undefined; | ||
| const timeoutPromise = timeout && delayedPromise(timeout).then(() => timeoutSymbol); | ||
| do { |
There was a problem hiding this comment.
the loop is over complicated. there is an initialization block hidden inside the do block.
| @@ -16,30 +16,34 @@ export interface RetryPromiseOptions { | |||
| timeoutMessage?: string; | |||
| } | |||
|
|
|||
| export function retryPromise<T>( | |||
| const timeoutSymbol = Symbol('timeout'); | |||
There was a problem hiding this comment.
no need to use a symbol.{} is enough.
| if (timeoutPromise) { | ||
| shouldDelay && await Promise.race([delayedPromise(interval), timeoutPromise]); | ||
| const result = await Promise.race([promiseProvider(), timeoutPromise]) | ||
| if (result === timeoutSymbol) { |
There was a problem hiding this comment.
if timeoutPromise would simply return timeoutPromise it would be much simpler.
| try { | ||
| if (timeoutPromise) { | ||
| shouldDelay && await Promise.race([delayedPromise(interval), timeoutPromise]); | ||
| const result = await Promise.race([promiseProvider(), timeoutPromise]) |
There was a problem hiding this comment.
there should not be a timeout on the operation itself
amir-arad
pushed a commit
that referenced
this pull request
Nov 28, 2017
* rewrite retry util * move test setup to script redundant with #94
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer creates an empty Promise without any use (
async (resolve, reject)=>...).No longer checks and rechecks whether it's in a timout.
When timeout value is provided, it creates a single delayed rejected promise and uses it with Promise.race when doing operations.
A unique object is used to identify a timeout error. First try was
class TimeoutError extends Error {}, butinstanceof TimeoutErroris false for IE11/Edge.