Lets add a screenBackgroundColor as a prop in navigatorStyle
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the view backgroundColor is white. This produces a white flickering for some of us when using dark backgroundColor in the <View />, because when we use push a new RootView is created and React styles applies not directly. So what happens is the following: 0. Navigator takes the registered component 1. Create a new ReactView, which has by default backgroundColor white! 2. Applies the navigation <Here we see the flickering> 3. React styles will get applied This commit adds a new navigatorStyle property `screenBackgroundColor`, which will get applied directly to the view as the backgroundColor, before React applies the backgroundColor from the actual styles.
ghost
mentioned this pull request
|
Hi, we wanted to update you that we are currently postponing the processing of pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the view backgroundColor is white. This produces a white flickering for some of us when using dark backgroundColor for the Screen View, because when we use navigator.push, a new RootView is created and React styles applies not directly. So what happens is the following:
This commit adds a new navigatorStyle property
screenBackgroundColor, which will get applied directly to the view as the backgroundColor, before React applies the backgroundColor from the actual styles.