This repository has been archived by the owner on Nov 27, 2021. It is now read-only.
[Pagination] Add Pagination component from wix-ui-base #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrauka
force-pushed
the
feature/pagination-component
branch
2 times, most recently
from
5ec7c86
to
0224d5e
Compare
|
Is there a UX spec for the paginati on component in wix-style-react in zeplin specs?
… On 2018. Sep 27., at 16:51, Karolis Astrauka ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#220
Commit Summary
[Pagination] Add Pagination component from wix-ui-base
File Changes
A src/components/Pagination/Pagination.driver.ts (3)
A src/components/Pagination/Pagination.e2e.ts (21)
A src/components/Pagination/Pagination.protractor.driver.ts (4)
A src/components/Pagination/Pagination.spec.tsx (33)
A src/components/Pagination/Pagination.st.css (61)
A src/components/Pagination/Pagination.tsx (17)
A src/components/Pagination/index.ts (4)
M src/testkit/enzyme.ts (3)
M src/testkit/index.ts (3)
M src/testkit/protractor.ts (3)
A stories/Pagination/index.story.tsx (29)
A stories/Pagination/storySettings.ts (7)
M stories/index.ts (1)
Patch Links:
https://github.com/wix/wix-ui-backoffice/pull/220.patch
https://github.com/wix/wix-ui-backoffice/pull/220.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Can you access https://zpl.io/bAEr6v8 ? |
astrauka
force-pushed
the
feature/pagination-component
branch
from
0224d5e
to
b6a427c
Compare
|
Created a PR for Pagination in wix-style-react https://github.com/wix/wix-style-react/pull/2281 |
|
this should live in wix-style-react and @astrauka has already created PR there, so closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.