Jest CLI options such as --onlyChanged don’t work

[sonicdoe]

Description

Jest CLI options such as --onlyChanged and --watch don’t work because Detox always passes the e2e directory.

✓ I have tested this issue on the latest Detox release and it still reproduces.

Reproduction

1. Clone DetoxTemplate.
2. Follow the instructions there.
3. npm install detox@18.19.0 --save-dev
4. npm run test:ios-debug -- --onlyChanged

Expected behavior

Jest understands the --onlyChanged option and only runs tests which have changed.

Suggested solution

Detox explicitly passes the e2e directory when invoking Jest, for example, jest --config e2e/config.json e2e. When specifying both --onlyChanged and e2e, Jest gives preference to e2e and runs all tests.

However, specifying e2e is not really necessary because Jest defaults to running all tests matching testMatch in the rootDir. For example, jest --config e2e/config.json also executes all tests.

Without e2e, options such as --onlyChanged work. For example, you can invoke Jest manually with:

$ DETOX_CONFIGURATION="ios.sim.debug" npx jest --config e2e/config.json --onlyChanged

Then, Jest properly exits with “No tests found related to files changed since last commit.”

Environment

• Detox: 18.19.0
• React Native: 0.64.4
• Node: 14.17.3

[noomorph]

@d4vidi, shall we add one more skipLegacySpecsInjection? 😆
P. S. Actually I am not that much kidding, the OP pointed at one more imprudent design solution of ours, circa 2017.

[noomorph]

@sonicdoe, may I suggest adding specs: ' ' to your Detox config? Make sure it has whitespace inside.

diff --git a/detox/test/e2e/detox.config.js b/detox/test/e2e/detox.config.js
index 215c13a0..44e0fafa 100644
--- a/detox/test/e2e/detox.config.js
+++ b/detox/test/e2e/detox.config.js
@@ -8,7 +8,7 @@ const launchArgs = {
 const config = {
   testRunner: 'nyc jest',
   runnerConfig: 'e2e/config.js',
-  specs: 'e2e/*.test.js',
+  specs: ' ',
   skipLegacyWorkersInjection: true,

   behavior: {

[sonicdoe]

Thanks, that works 👍 By the way, this specs option doesn’t seem to be documented in the configuration options.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[sonicdoe]

This issue is still present in Detox v18.20.2.

[d4vidi]

@noomorph something to address this week, maybe?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[sonicdoe]

This issue is still present in Detox v18.22.0.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[sonicdoe]

I haven’t tested it again, but looking at the changelog, I assume this is still present in the latest version.

[noomorph]

This will be a breaking change.
I added it to the plan to Detox 20: #2838
Also, related issue: #3076

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[sonicdoe]

I haven’t tested it again, but I assume this issue is still relevant.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[sonicdoe]

I haven’t tested it again, but I assume this issue is still relevant.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[sonicdoe]

I haven’t tested it again, but I assume this issue is still relevant.

[d4vidi]

@noomorph wouldn't it be better off if the issue is merged with Detox 20?
Also, is platform: non-specific better than not specifying the platform altogehter?

[noomorph]

I think this issue is no longer relevant for Detox 20.

Please create a new one if something does not work.
We don't use specs anymore.

[sonicdoe]

Thanks! I can confirm that --onlyChanged now works properly with Detox v20.

[noomorph]

@sonicdoe let me know if you experience issues in -R, --retries mode. I think this is likely, so if it confirms, I'll fix it.

[sonicdoe]

As far as I can tell, --onlyChanged works fine with --retries; it respawns jest with --onlyChanged and the failed test file. If there are no changed files, it immediately exits and doesn’t retry anything.