Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox CLI: Replace commander with argparse #767

Closed
rotemmiz opened this issue Jun 3, 2018 · 3 comments
Closed

Detox CLI: Replace commander with argparse #767

rotemmiz opened this issue Jun 3, 2018 · 3 comments

Comments

@rotemmiz
Copy link
Member

rotemmiz commented Jun 3, 2018

commander has basic parsing issues which haven't been addressed for more than 3 years!

Let's abandon it and move to something else.
argparse looks good enough, but it's open for suggestions. We need to up our game in detox-cli, code quality is not great, especially when things get a bit complicated, where we override package.json configuration etc.

@yershalom
Copy link
Contributor

We can use this http://nodeca.github.io/argparse/ , looks like it solves the parsing issues.

DanielMSchmidt pushed a commit that referenced this issue Jul 25, 2018
@LeoNatan
Copy link
Contributor

@noomorph Does the transition to yargs close this issue?

@noomorph
Copy link
Collaborator

Yes, thanks for checking! Closing it.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants