Add a create-e2e command #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
requested changes
Apr 20, 2017
detox/local-cli/detox-create-e2e.js
Outdated
| var fs = require('fs'); | ||
| var dir = './e2e'; | ||
|
|
||
| var mochaOptsContent= '--recursive --timeout 120000 --bail' |
detox/local-cli/detox-create-e2e.js
Outdated
|
|
||
| if (!fs.existsSync(dir)){ | ||
| fs.mkdirSync(dir); | ||
| fs.writeFileSync("./e2e/mocha.opts", mochaOptsContent, function(err) { |
There was a problem hiding this comment.
use arrow functions instead of function
detox/local-cli/detox-create-e2e.js
Outdated
| after(async () => { | ||
| await detox.cleanup(); | ||
| });` | ||
| var firstTestContent = `describe('Example', () => { |
There was a problem hiding this comment.
I think we should provide an empty firstTest.spec.js file.
something like:
describe('', () => {
beforeEach(async () => {
await device.reloadReactNative();
});
it('', async () => {
});
}
detox/local-cli/detox-create-e2e.js
Outdated
| if(err) { | ||
| return console.log(err); | ||
| } | ||
| console.log("The file was saved!"); |
There was a problem hiding this comment.
- We need a more descriptive log here, something like "Test files for were created in "
detox/local-cli/detox-create-e2e.js
Outdated
| @@ -0,0 +1,60 @@ | |||
| var fs = require('fs'); | |||
There was a problem hiding this comment.
add commander params to support multiple test runners (you can set mocha as default), and make it easy to add more templates for other test runners in the future.
This means moving all the templates to a different file (templates.mocha.js ?) and creating a switch like we have in detox-test.js
detox/local-cli/detox-create-e2e.js
Outdated
| } | ||
| console.log("The file was saved!"); | ||
| }); | ||
| fs.writeFileSync("./e2e/init.js", initjsContent, function(err) { |
There was a problem hiding this comment.
There's code duplication here, please create a function
detox/local-cli/detox-create-e2e.js
Outdated
| }); | ||
| fs.writeFileSync("./e2e/init.js", initjsContent, function(err) { | ||
| if(err) { | ||
| return console.log(err); |
There was a problem hiding this comment.
return the err, not the console.log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a create-e2e command to create the e2e folder and the init.js, mocha.opts and myFirstTest.spec.js files inside it automatically