Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #117

Merged
merged 2 commits into from
Apr 25, 2017
Merged

Update README.md #117

merged 2 commits into from
Apr 25, 2017

Conversation

dassir
Copy link
Contributor

@dassir dassir commented Apr 24, 2017

pure native android demo documentation - updated to 'not supported'

@dassir
Update README.md
86abac0 
pure native android demo documentation  -updated to 'not supported'
rotemmiz
rotemmiz reviewed Apr 24, 2017
View reviewed changes
Copy link
Member

@rotemmiz rotemmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it to be as clear as possible, what about something like:

"Android is not supported in detox yet. This project is there for development purposes and is not working yet."?

@dassir
Copy link
Contributor Author

dassir commented Apr 24, 2017

Agreed. Although, I'm not sure we should keep the 'how to' instructions. Might be confusing for some.

@rotemmiz
Copy link
Member

Agreed, you can delete the instructions

@dassir
Update README.md
3574a7a 
refined readme and removed instructions
@rotemmiz rotemmiz merged commit be35edb into wix:master Apr 25, 2017
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz rotemmiz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dassir @rotemmiz