Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encapsulate the path in "adb.EXE devices" call #1739

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

forki
Copy link
Contributor

@forki forki commented Nov 6, 2019

@forki forki requested a review from rotemmiz as a code owner November 6, 2019 13:10
@noomorph
Copy link
Collaborator

noomorph commented Nov 6, 2019

Please update unit tests.

@forki
Copy link
Contributor Author

forki commented Nov 6, 2019

@noomorph I'm a newcomer could you please point me to the ones that I broke?

@noomorph
Copy link
Collaborator

noomorph commented Nov 6, 2019 via email

@forki
Copy link
Contributor Author

forki commented Nov 7, 2019

I think the unittests are now fixed

@noomorph noomorph merged commit fdc169e into wix:master Nov 7, 2019
@forki forki deleted the patch-1 branch November 8, 2019 14:09
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants