fix(instruments): should not crash if the app was terminated inside a test #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
force-pushed
the
fix/record-instruments-in-terminated-app
branch
from
fd0f611
to
ca4bf65
Compare
noomorph
force-pushed
the
fix/record-instruments-in-terminated-app
branch
from
ca4bf65
to
c64d98f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If we terminate a tested app inside a test, then the test next to it won't pass if you have
--record-performance allflag turned on. 😞 Detox tries to sendsetRecordingStateviaClient.jsright insidebeforeEachphase, which is a bad idea in the case when the app is not running.