(Android) Introduce ANR monitor to produce warn-logs #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
force-pushed
the
anr-logging
branch
2 times, most recently
from
a83af02
to
32f994d
Compare
d4vidi
commented
Feb 24, 2020
| Detox = require('./Detox'); | ||
| detox = new Detox({deviceConfig: validDeviceConfigWithSession}); | ||
| await detox.init(); | ||
| detox._client.getPendingCrashAndReset.mockReturnValueOnce('crash'); // TODO: rewrite to avoid accessing private fields |
d4vidi
commented
Feb 24, 2020
| @@ -57,6 +57,7 @@ class Detox { | |||
| } | |||
|
|
|||
| this._client = new Client(sessionConfig); | |||
| this._client.setNonresponsivenessListener(this._onNonresnponsivenessEvent.bind(this)); | |||
There was a problem hiding this comment.
@noomorph I was far from sure as to whether this is the right level for this work-scope. I'd be happy to get your insights on this (for example, should this be part of the client's implementation?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Resolves #1925. Introduces usage of the very interesting ANR-WatchDog project for the sake of ANR-state proximation. The ends result is a warning on the Detox (tester) side with a main-thread stacktrace, when main-thread blockage is detected, alongside a complete thread-dump on the device logs.
Integration of it all was pretty straightforward, but testing this (e2e) was a bit of a pain since logs are not easy to intercept.