New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): external configuration files #2050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
force-pushed
the
feat/external-config
branch
from
May 21, 2020 07:27
13f99c7
to
a2dea79
Compare
Pull Request Test Coverage Report for Build 2170
💛 - Coveralls |
noomorph
force-pushed
the
feat/external-config
branch
from
May 22, 2020 17:12
05936f5
to
d09b360
Compare
noomorph
force-pushed
the
feat/external-config
branch
from
May 22, 2020 17:46
d09b360
to
d221153
Compare
noomorph
force-pushed
the
feat/external-config
branch
4 times, most recently
from
May 25, 2020 14:46
e2bfb28
to
a6ae396
Compare
noomorph
force-pushed
the
feat/external-config
branch
6 times, most recently
from
May 25, 2020 16:03
33e2ecf
to
cde4934
Compare
noomorph
force-pushed
the
feat/external-config
branch
from
May 25, 2020 16:16
cde4934
to
c8d2173
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #901.
Description:
detox.init(config[, userParams])
signature.a. Renames
config
toconfigOverride
. Speaking lodash language, we deep-merge:_.merge(configFromFile, configOverride)
. Also,userParams
parameter is redundant, since you can tweak its behavior via the firstconfigOverride
parameter, or right in the config file. Below is an example for sake of the demonstration:configFromFile
variable, it represents Detox configuration object, imported either from.detoxrc
,.detoxrc.json
,.detoxrc.js
,detox.config.json
,detox.config.js
,package.json
(detox section) in the current working directory, or fromprocess.env.configPath
(--config-path
CLI argument) path override. If you are usingdetox-cli
, you will have to specify--config-path path/to/.detoxrc
parameter to pass it explicitly tomocha
orjest
runner.Acknowledgements:
Thanks to @Debens and @oreporan for their early work on this feature. It took long to implement this feature, though the path we walked wasn't short and easy either - there were many configuration refactors preceding it. 🤔