Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting rn-context load time in DetoxTest #2231

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Jul 27, 2020

  • This is a small change
  • This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:
Resolves #2197. Migrates Detox' idle-policy config to a more generic config structure (that handles idle-policy as well), such that it can also hold a custom timeout for waiting for RN's loading to complete. That enables, for example, the customization of the timeout based on whether the app running in debug mode rather than release - where this can take longer for large apps. See here.

@d4vidi
Copy link
Collaborator Author

d4vidi commented Jul 27, 2020

@swabbass

@d4vidi d4vidi force-pushed the detox-android-test-config branch from abb801d to 5413f3b Compare July 27, 2020 19:25
@swabbass
Copy link
Contributor

swabbass commented Jul 28, 2020

  • This is a small change
  • This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:
Resolves #2197. Migrates Detox' idle-policy config to a more generic config structure (that handles idle-policy as well), such that it can also hold a custom timeout for waiting for RN's loading to complete. That enables, for example, the customization of the timeout based on whether the app running in debug mode rather than release - where this can take longer for large apps. See here.

THX A LOT Wating for this to release to use it.
not a reviewer but wrote my thoughts on kotlin code might be useful :],

@swabbass swabbass closed this Jul 28, 2020
@swabbass swabbass reopened this Jul 28, 2020
@coveralls
Copy link

coveralls commented Jul 28, 2020

Pull Request Test Coverage Report for Build 2506

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.661%

Totals Coverage Status
Change from base Build 1315: 0.04%
Covered Lines: 3636
Relevant Lines: 4080

💛 - Coveralls

@d4vidi d4vidi merged commit 9d795ac into master Jul 28, 2020
@d4vidi d4vidi deleted the detox-android-test-config branch July 28, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waited a whole minute for the new RN-context
3 participants