fix: image for visibility testing when window is a keyboard #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I somehow missed this PR while going over #2754... Thank you!!! |
|
Offhand, I see that we're going to need an integrated e2e test case in order to accept this. |
|
@tyronet-sportsbet Thanks for the PR! |
|
I have attempted to add an E2E test as requested, I hope what I've done is acceptable. I'm not sure why the Android job on Jenkins is failing, I'm not really familiar with Android / Detox's CI enough to parse what's going on in those logs, so if someone could give me a steer there I'll fix it ASAP. |
|
Merged! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have changed the image for visibility testing logic so it no longer overlays keyboards when the keyboard is the window being tested.
(This is not a feature or enhancement, it's a bug fix)
(This does not change the API surface)