adjustSliderToPosition on Android #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/full/java/com/wix/detox/espresso/matcher/ViewMatchers.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/full/java/com/wix/detox/espresso/matcher/ViewMatchers.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/full/java/com/wix/detox/espresso/matcher/ViewMatchers.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/full/java/com/wix/detox/espresso/matcher/ViewMatchers.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
...id/detox/src/testFull/java/com/wix/detox/espresso/action/AdjustSliderToPositionActionTest.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/main/java/com/wix/detox/espresso/action/AdjustSliderToPositionAction.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/main/java/com/wix/detox/espresso/action/AdjustSliderToPositionAction.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/main/java/com/wix/detox/espresso/action/AdjustSliderToPositionAction.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/main/java/com/wix/detox/espresso/action/AdjustSliderToPositionAction.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/main/java/com/wix/detox/espresso/action/AdjustSliderToPositionAction.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
detox/android/detox/src/main/java/com/wix/detox/espresso/action/AdjustSliderToPositionAction.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
...id/detox/src/testFull/java/com/wix/detox/espresso/action/AdjustSliderToPositionActionTest.kt
Show resolved
Hide resolved
d4vidi
reviewed
Jul 19, 2021
d4vidi
reviewed
Jul 19, 2021
|
Hey, thanks for all the work! 🙏🏻 |
noomorph
reviewed
Jul 21, 2021
noomorph
reviewed
Jul 21, 2021
noomorph
requested changes
Jul 21, 2021
There was a problem hiding this comment.
Generally looks good on the JS side, but I wonder that you added API to waitFor chains, but it is not properly tested anywhere.
Also, the percent handling (iOS only) is better off being documented as not supported on Android, or maybe we can handle strings that .endsWith('%') and just parseFloat(...) * 0.01, all on JS side?
jonathanmos
force-pushed
the
slider-adjust-to-position
branch
from
67213b7
to
58419ee
Compare
# Conflicts: # detox/android/detox/src/full/java/com/wix/detox/espresso/DetoxAction.java # detox/src/android/actions/native.js # detox/src/android/espressoapi/DetoxAction.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding adjustSliderToPosition and toHaveSliderPosition for Android - addresses #2792.