New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fishhook submodule #3021
Conversation
@d4vidi feel free to use this PR and the ones on DetoxSync & ObjectiveCHelpers or close in favor of yours, did not see you had one you were working on. Thank you again π |
@calebmackdavenport my PR was just for some shallow testing. |
* update commits * use detoxsync fishhook branch * Fix gitmodules
π Tests pass π Not to over-explain if this is obvious, but I can't both have jenkins passing and be merge-ready. I am pointing at commits that exist on: But do not exist on: As mentioned, please feel free to modify/edit/massage this PR as well as I am not the most familiar with submodules so definitely dismiss this or correct me, but it would probably easiest to:
|
@calebmackdavenport thanks again for all of this. We found ourselves in the need for a more thorough cleanup (i.e. more than just adjusting the submodules' commits). We will give you all the credit when done ππ» |
Awesome! Thank you and @asafkorem for the hard work π |
I'm closing this PR, the changes will take place in #3027. |
Description
Please feel free to edit this PR as much as you like.
In this pull request, I have β¦
Updated fishhook π facebook/fishhook@aadc161 π
Thanks to @mikehardy #2895 (comment) for keeping an eye on fishhook and probably influencing the merge.
DetoxSync PR: wix-incubator/DetoxSync#11 (Also updates the submodule to grab existing dependabot updates)
DTXObjectiveCHelpers PR: wix-incubator/DTXObjectiveCHelpers#1
This fishhook fix resolves specifically the issue shown here: #2895 (comment)
Error Code: 0x00000007 (invalid protections for user data write)
Previous PR #3020