Support community slider #3300
Merged
Support community slider #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I was about to review, then realized that there's slightly more to this than I had imagined. I will get back to it next week. |
d4vidi
reviewed
Apr 10, 2022
d4vidi
reviewed
Apr 10, 2022
|
|
||
| private const val TEST_CLASS = "com.facebook.react.views.slider.ReactSlider" | ||
|
|
||
| class ReflectUtilsTest { |
There was a problem hiding this comment.
Nice!
- Could you Spek it? Or do you think we shouldn't?
- Could you also check for the
return truecase?
d4vidi
reviewed
Apr 10, 2022
detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/ReflectUtils.kt
Outdated
Show resolved
Hide resolved
|
Hmmm, nice PR. Good job, @jonathanmos ! 👍 |
d4vidi
force-pushed
the
support-community-slider
branch
from
ac7a1ad
to
7ef7156
Compare
d4vidi
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the Community Slider.