Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated native IdlePolicyConfig #3332

Merged
merged 1 commit into from Apr 14, 2022
Merged

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Apr 14, 2022

Description

In this pull request, I have had the deprecated DetoxIdlePolicyConfig class removed from the Android native code.

Also added this as a WIP bullet under #3285.


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi requested a review from noomorph April 14, 2022 11:43
@d4vidi d4vidi self-assigned this Apr 14, 2022
@noomorph
Copy link
Collaborator

@d4vidi is there any migration guide for this? or this is something very-very old and not documented?

@d4vidi
Copy link
Collaborator Author

d4vidi commented Apr 14, 2022

@noomorph I imagine there would be a guide for the v20 migration, shouldn't there be? The fix for this is super easy and can be integrated with 0 effort. Also, it's very old as you said.

@noomorph noomorph merged commit c9483c1 into next Apr 14, 2022
@noomorph noomorph deleted the deprecate-IdlePolicyConfig branch April 14, 2022 12:54
This was referenced Apr 25, 2022
noomorph pushed a commit that referenced this pull request Apr 27, 2022
noomorph pushed a commit that referenced this pull request May 3, 2022
noomorph pushed a commit that referenced this pull request May 13, 2022
noomorph added a commit that referenced this pull request Nov 10, 2022
* feat: set minimal Node requirement to 14.5.x
* feat: drop old Jest integrations

BREAKING CHANGE: please upgrade to jest-circus
https://wix.github.io/Detox/docs/guide/jest/

* feat(config): drop default "e2e" value for specs (#3289)

BREAKING CHANGE: Detox won't be appending "e2e" glob to the test runner
if it is not explicitly configured to do so via "specs" property in the
config.

* feat(config): drop skipLegacyWorkersInjection (#3286)

BREAKING CHANGE: Detox will no longer be injecting "-w 1" to Jest as CLI
arguments

* feat(android): boot read-only emulators by default

* feat(iOS): support --headless config (#3304)

BREAKING: opens Simulator app by default unless the headless mode is enabled

* feat: drop Mocha support (#3310)

BREAKING: Detox users should migrate to Jest

* feat(android): remove deprecated native IdlePolicyConfig (#3332)

BREAKING CHANGE

* feat: drop device.appLaunchArgs [options] argument (#3360)

BREAKING: use device.appLaunchArgs.shared for permanent operations

* feat: remove ios.none device type (#3361)

* feat: undeprecate device.relaunchApp() (#3362)

* feat(config): remove legacy dash-based props (#3371)

BREAKING: removes test-runner and runner-config props
from Detox global config. Use testRunner and runnerConfig
instead.

* feat(config): drop support for the all-in-one configuration format (#3386)

BREAKING: please migrate to the new { apps, devices, configurations }
schema that Detox has been already using for more than a year.

* feat: drop jest<27.2.5 support (#3392)

BREAKING: please migrate your projects to Jest 28.x or 27.x

* fix(ios): headless mode

* feat: new global lifecycle for Detox (#3333)

* fix(cli): forward env overrides anyway

* feat(config): add testRunner.forwardEnv

Also, fixes --inspect-brk debugging experience.
Now the entire debug happens in a single test runner process.

* feat(api): detoxInternals.tracing.createEventStream

* feat(config): add reversePorts to app config (#3610)

* fix(Android): pass `headless` config param to the AVD validator. (#3614)

* feat(cli): add reset-lock-file command

* website: add Showcase page

* website: homepage changes

* feat(cli): drop --device-launch-args arg (#3665)

BREAKING: use --device-boot-args instead

Co-authored-by: Asaf Korem <asaf.korem@gmail.com>
Co-authored-by: d4vidi <amit.d4vidi@gmail.com>
Co-authored-by: jasonbariwix <jasonba@wix.com>
Co-authored-by: Yevheniia Hlovatska <33955728+evgeniyaglovatskaya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants