Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genycloud: Omit preliminary login check #4379

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Feb 22, 2024

Description

In this pull request, I have removed Detox's preliminary check for proper Genymotion-login. This stems from Genymotion's deprecation of this command in gmsaas v1.10.0.

It was a nice-to-have to begin with, so Detox should be fine without it: The error is reported by the gmsaas command itself at runtime. It's a subtle degradation of dev-ex, but nothing alarming.

@lilinor @igorgn


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi self-assigned this Feb 22, 2024
@d4vidi d4vidi merged commit fd0f359 into master Feb 22, 2024
3 checks passed
@d4vidi d4vidi deleted the genycloud-omit-login-check branch February 22, 2024 16:32
@lilinor
Copy link
Contributor

lilinor commented Feb 23, 2024

Hi @d4vidi !
Just for your information, the gmsaas doctor command is planned to be released max in 2 weeks :)

@d4vidi
Copy link
Collaborator Author

d4vidi commented Feb 25, 2024

Hi @d4vidi ! Just for your information, the gmsaas doctor command is planned to be released max in 2 weeks :)

Thanks! We will tune-in to that when ready

@agavignet
Copy link

agavignet commented Mar 20, 2024

Hi @d4vidi

I just let you known that gmsaas 1.11.0 has been released, introducing gmsaas doctor as well as fixing a compability issue with Python 3.12.

Here are few samples:

gmsaas doctor OK (exit code 0)

$ gmsaas doctor
Check up finished:
- Authentication OK.
- Android SDK OK.
$ gmsaas --format json doctor
{
    "issues": [],
    "exit_code": 0,
    "exit_code_desc": "NO_ERROR"
}

gmsaas doctor NOK (exit code 1)

$ gmsaas doctor
Error: gmsaas is not configured properly
One or several issues have been detected:
- Authentication failed.
- Android SDK not configured.
$ gmsaas --format json doctor
{
    "error": {
        "message": "Error: gmsaas is not configured properly",
        "details": "",
        "issues": [
            "Authentication failed.",
            "Android SDK not configured."
        ]
    },
    "exit_code": 1,
    "exit_code_desc": "DEFAULT_ERROR"
}

Best regards

@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 20, 2024

@agavignet thank you! We've received the update via the RSS subscription 😄
Could you elaborate (here/DM) on what's being done under the hood? Ideally, I'd like to know it's safe enough to apply as an error, or rather we should resort to a warning.

@d4vidi d4vidi mentioned this pull request Mar 20, 2024
@agavignet
Copy link

@agavignet thank you! We've received the update via the RSS subscription 😄 Could you elaborate (here/DM) on what's being done under the hood? Ideally, I'd like to know it's safe enough to apply as an error, or rather we should resort to a warning.

Sure, for the authentication check, a real API call is made so if the test pass it means the API Token (or legacy credentials) are OK.
For the ADB check, we ensure adb binary is found regarding the Android Sdk path provided and has execution rights.

If gmsaas doctor fails, you can consider this as an error :)

@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 21, 2024

@agavignet thank you! We've received the update via the RSS subscription 😄 Could you elaborate (here/DM) on what's being done under the hood? Ideally, I'd like to know it's safe enough to apply as an error, or rather we should resort to a warning.

Sure, for the authentication check, a real API call is made so if the test pass it means the API Token (or legacy credentials) are OK. For the ADB check, we ensure adb binary is found regarding the Android Sdk path provided and has execution rights.

If gmsaas doctor fails, you can consider this as an error :)

SGTM, thanks 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants