-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genycloud: Omit preliminary login check #4379
Conversation
Hi @d4vidi ! |
Thanks! We will tune-in to that when ready |
Hi @d4vidi I just let you known that Here are few samples: gmsaas doctor OK (exit code 0)
gmsaas doctor NOK (exit code 1)
Best regards |
@agavignet thank you! We've received the update via the RSS subscription 😄 |
Sure, for the authentication check, a real API call is made so if the test pass it means the API Token (or legacy credentials) are OK. If |
SGTM, thanks 🙏🏻 |
Description
In this pull request, I have removed Detox's preliminary check for proper Genymotion-login. This stems from Genymotion's deprecation of this command in gmsaas
v1.10.0
.It was a nice-to-have to begin with, so Detox should be fine without it: The error is reported by the
gmsaas
command itself at runtime. It's a subtle degradation of dev-ex, but nothing alarming.@lilinor @igorgn