Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed postintall for non react native projects #4430

Merged
merged 2 commits into from Apr 2, 2024
Merged

fixed postintall for non react native projects #4430

merged 2 commits into from Apr 2, 2024

Conversation

gosha212
Copy link
Contributor

Description

In this pull request, I have fixed the postinstall for non RN projects

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@gosha212 gosha212 linked an issue Mar 31, 2024 that may be closed by this pull request
Detox postinstall fails in non-React Native projects #4408
Closed
1 task
noomorph
noomorph approved these changes Mar 31, 2024
View reviewed changes
Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much work will it be to handle the version as "maybe null" object?

@gosha212 gosha212 merged commit 922f412 into master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noomorph noomorph noomorph approved these changes

@d4vidi d4vidi Awaiting requested review from d4vidi d4vidi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detox postinstall fails in non-React Native projects
2 participants
@gosha212 @noomorph