Added condition wrapper for only R.N vs supported

[Rolando-Barbella]

Description

Following issue #4445 I added a condition that limits react logger for not supported versions as @d4vidi recommend it

[d4vidi]

Hey @Rolando-Barbella,
thanks a lot for this request!
It's the right direction, but I was aiming for an if to be implemented under the attach() method (i.e. making the logger a no-op). I will definitely accept and merge that. In any case, why is the condition minor ≥ 71000 and not ≥71?

[Rolando-Barbella]

Hi @d4vidi thanks for the feedback, I just updated the branch with the changes, hopefully it makes more sense now

[d4vidi]

@Rolando-Barbella you don't need the isLoggerEnabled toggle. The entire class is a listener which unless registered, it does nothing.

[Rolando-Barbella]

@d4vidi sorry, I have little experience with Kotlin, if the logic inside the attach method is not needed, what do you mean by an if to be implemented under the attach() method (i.e. making the logger a no-op) ?

Do you consider something like this?

---

object ReactMarkersLogger : ReactMarker.MarkerListener {

    fun attach() {
        ReactMarker.addListener(this)
    }

    override fun logMarker(marker: ReactMarkerConstants, p1: String?, p2: Int) {
        val isMarkerValid = when (marker) {
            DOWNLOAD_START,
            DOWNLOAD_END,
            BUILD_REACT_INSTANCE_MANAGER_START,
            BUILD_REACT_INSTANCE_MANAGER_END,
            REACT_BRIDGE_LOADING_START,
            REACT_BRIDGE_LOADING_END,
            REACT_BRIDGELESS_LOADING_START,
            REACT_BRIDGELESS_LOADING_END,
            CREATE_MODULE_START,
            CREATE_MODULE_END,
            NATIVE_MODULE_SETUP_START,
            NATIVE_MODULE_SETUP_END,
            PRE_RUN_JS_BUNDLE_START,
            RUN_JS_BUNDLE_START,
            RUN_JS_BUNDLE_END,
            CONTENT_APPEARED,
            CREATE_CATALYST_INSTANCE_START,
            CREATE_CATALYST_INSTANCE_END,
            DESTROY_CATALYST_INSTANCE_START,
            DESTROY_CATALYST_INSTANCE_END,
            CREATE_REACT_CONTEXT_START,
            CREATE_REACT_CONTEXT_END,
            PROCESS_PACKAGES_START,
            PROCESS_PACKAGES_END -> true
            else -> false
        }

        if (isMarkerValid && ReactNativeInfo.rnVersion().minor >= 71) {
            Log.d("Detox.RNMarker", "$marker ($p1)")
        }
    }
}

[d4vidi]

@Rolando-Barbella check out my suggestion. This is everything you need.

[d4vidi]

Suggested change

	if (ReactNativeInfo.rnVersion().minor >= 71) {
	isLoggerEnabled = true
	} else {
	ReactMarker.addListener(this)
	}
	if (ReactNativeInfo.rnVersion().minor >= 71) {
	ReactMarker.addListener(this)
	}

[Rolando-Barbella]

@d4vidi much simpler approach! I updated the branch, thank you