fix(Types):Fixed the types of whileElement to be aligned with the documentation … #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's emphasize this on our docs (only scroll is allowed) |
noomorph
reviewed
May 9, 2024
| * @example await element(by.id('scrollView')).scroll(100, 'down', NaN, 0.85); | ||
| * @example await element(by.id('scrollView')).scroll(100, 'up'); | ||
| */ | ||
| scroll( |
There was a problem hiding this comment.
Please add an extra test to:
Invoke the waitFor(...).scroll(pixels, direction, startX, startY, in addition to (pixels, directions).
Besides, you can add one more test like // @ts-expect-error to ensure that waitFor(...) does not have tap or some other common method.
noomorph
approved these changes
May 9, 2024
|
Released with Detox 20.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and the reality
Description
In this pull request, I have removed the unsupported actions from waitFor().whileElement()