Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Webpack + CommonJS Package Manager #152

Merged
merged 3 commits into from Jul 29, 2015

Conversation

benoror
Copy link
Contributor

@benoror benoror commented Jul 28, 2015

Motivation

Hi!

I'm in the process of refactoring an app to support modern JS tooling like Webpack & ES6.
A small change is needed to support CommonJS:

Code Change

/* commonjs package manager support (eg componentjs) */
if (typeof module !== "undefined" && typeof exports !== "undefined" && module.exports === exports){
  module.exports = 'angular-md5';
}

*Source: ui-router release

Working Examples

Sources

@yoavaa yoavaa merged commit 3aaf29f into wix-incubator:master Jul 29, 2015
@yoavaa
Copy link
Contributor

yoavaa commented Jul 29, 2015

Thanks 👍

@benoror
Copy link
Contributor Author

benoror commented Jul 29, 2015

Happy to help!

@benoror
Copy link
Contributor Author

benoror commented Jul 29, 2015

@yoavaa Could you please tag a newer version (0.2.13 or something, package.json & bower.json) in order to pusblish it to npmjs: https://www.npmjs.com/package/angular-tree-control

I can register you as collaborator as well, I only need your npmjs username 😄

Cheers!

@benoror benoror mentioned this pull request Jul 29, 2015
@benoror
Copy link
Contributor Author

benoror commented Jul 29, 2015

Ok done it already, you just have to merge it & tag it and I can publish it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants