Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for jQuery 2.2.2. #203

Merged
merged 2 commits into from
Apr 7, 2016
Merged

Conversation

andyskw
Copy link

@andyskw andyskw commented Mar 21, 2016

I've just dumb-bumped the jquery dependency in the project, and the bundled "demo" jquery.js to the latest version, as there is a known security vulnerability in jquery 2.0.3 - jquery/jquery#2432.

Please review the pull request, and in case if the version bump of jquery - removing the known vulnerability from angular-tree-control - seems to make sense, consider merging it and creating a security maintenance release for angular-tree-control.

In case if there are any hidden dependencies/issues caused by this pull request, please let me know, and I'll fix them as soon as possible! :) I've checked the updated demo index.html, and it seems like, this change did not introduce any new issues (however there were issues around the "Events" part, but I decided, they are out of scope for this PR.)

@andyskw
Copy link
Author

andyskw commented Mar 23, 2016

@yoavaa, is there anything I can help you with in order to get the PR merged?

@andyskw
Copy link
Author

andyskw commented Apr 7, 2016

@yoavaa ping?

@yoavaa yoavaa merged commit 3c57dbd into wix-incubator:master Apr 7, 2016
@andyskw
Copy link
Author

andyskw commented Apr 7, 2016

Wow, thanks! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants