-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the possibility to specify a test runner path besides from local ./node_modules #753
Conversation
This reverts commit f4f29de.
fixed a conflict with my "runnerPath" and @simonbuchan "binPath". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of all the format diffs, though it does look like there is some mixed indentation already.
Instead of adding another property, this could instead check if the runner has a path separator (/
on posix, either /
or \
on windows), and simply not path join it in that case: e.g. ./my-script
is in the working dir. For windows support, you still should normalise the path to use \
- it's only required for commands run by the windows shell, but that's what's happening here.
thanks @simonbuchan, I actually removed a binPath left behind... As I submitted the PR before your's got merged I didn't resolve the conflicts properly because I was working on something else... Now everything should be fine 🙌 |
@simonbuchan @rotemmiz anything else that I need for this to get merged? |
I'm trying to think this through, but I fail to get convinced this is valid solution. Seems like your project setup might get encountered in many issues of this type on other tools, not just Detox. I have a feeling that in your usecase it might be smarter to just add the .bin of other projects in the monorepo to your project path. |
This PR is for issue #752, I hope you guys find it useful since it is the only way I can make it work on my current project 👐