Feat/ timeline x days view #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
May 16, 2022
ethanshar
reviewed
May 23, 2022
ethanshar
reviewed
May 23, 2022
ethanshar
reviewed
May 25, 2022
| @@ -44,6 +44,8 @@ export interface CalendarContextProviderProps extends ViewProps { | |||
| disabledOpacity?: number; | |||
| /** The number of days to present in the timeline calendar */ | |||
| numberOfDays?: number; | |||
| /** The left inset of the timeline calendar (sidebar width), default is 72 */ | |||
| leftInset?: number; | |||
There was a problem hiding this comment.
Does it make sense to call this prop timelineLeftInset or timelineSidebarWidth - this way the prop name also hints it's only relevant to Timeline. leftInset feels too general
There was a problem hiding this comment.
Changed to timelineLeftInset
src/expandableCalendar/index.tsx
Outdated
| @@ -98,7 +98,7 @@ const headerStyleOverride = { | |||
| */ | |||
|
|
|||
| const ExpandableCalendar = (props: ExpandableCalendarProps) => { | |||
| const {date, setDate, numberOfDays = 1} = useContext(Context); | |||
| const {date, setDate, numberOfDays = 1, leftInset = 72} = useContext(Context); | |||
There was a problem hiding this comment.
We're setting the 72 default values in several places.
if we'll need to change it in the future we might miss one instance and have a bug.
Can we maybe set its default once in the context value?
ethanshar
approved these changes
Jun 7, 2022
|
@ethanshar @lidord-wix Don't you want to merge this one? |
@Inbal-Tish no, it requires a QA session |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeline x days view
To see the changes, please uncomment line # 242 in the timelineCalendarScreen (and you can change it to any other number from 1 to 7)
And sorry about this big PR 馃檲
WOAUILIB-2613