CalendarContextProvider - use with pure functions #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Jul 12, 2022
Comment on lines
73
to
77
| const [prevDate, setPrevDate] = useState(date); | ||
| const [currentDate, setCurrentDate] = useState(date); | ||
| const [updateSource, setUpdateSource] = useState(UpdateSources.CALENDAR_INIT); | ||
| const [isDisabled, setIsDisabled] = useState(false); | ||
| const [buttonIcon, setButtonIcon] = useState(getButtonIcon(date, showTodayButton)); |
There was a problem hiding this comment.
Move useState's before useMemo's
| setUpdateSource(updateSource); | ||
| setButtonIcon(buttonIcon); | ||
| }; | ||
| setPrevDate(currentDate); |
There was a problem hiding this comment.
I wonder of these calls trigger multiple renders
There was a problem hiding this comment.
When I log the provider, I see one call after setDate.
…nfra/CalendarContextProvider_change_presenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
setDateandsetDisabledback to Provider and removing the Presenter's relevant tests