Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week calendar refactor #1961

Merged
merged 44 commits into from Sep 18, 2022
Merged

Week calendar refactor #1961

merged 44 commits into from Sep 18, 2022

Conversation

yuvalsho
Copy link
Contributor

@yuvalsho yuvalsho commented Aug 7, 2022

No description provided.

@Inbal-Tish Inbal-Tish self-assigned this Aug 7, 2022
@Inbal-Tish
Copy link
Collaborator

@yuvalsho Can you please check the conflicts and the failing build?

@Inbal-Tish
Copy link
Collaborator

@yuvalsho Hi. Please pull master and resolve conflicts

@Inbal-Tish
Copy link
Collaborator

@yuvalsho Overall looks and feels good. Just a few comments about this PR's scope and some code standards.
Also, I did find some little bugs, not only in the ExpandableCalendarScreen but also in other screens, like WeekCalendarScreen and TimelineCalendarScreen (with 'numberOfDays` passed). Need to make sure we're not breaking anything in the process...

@Inbal-Tish
Copy link
Collaborator

@yuvalsho When passing disableWeekScroll prop the calendar not working properly.

@Inbal-Tish
Copy link
Collaborator

@yuvalsho Hi. Can you please resolve conflict and let's merge this?

@yuvalsho yuvalsho merged commit 8d4f36b into master Sep 18, 2022
@yuvalsho yuvalsho deleted the week-calendar-refactor branch September 18, 2022 12:13
@TomCorvus TomCorvus mentioned this pull request Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuvalsho @Inbal-Tish