add integration tests on expandable calendar #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Nov 10, 2022
|
@yuvalsho expandableCalendar tests faild |
Inbal-Tish
reviewed
Nov 10, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
Inbal-Tish
reviewed
Nov 13, 2022
| expect(onDateChanged).toHaveBeenCalledWith(toMarkingFormat(expectedDate), UpdateSources.PAGE_SCROLL); | ||
| }); | ||
|
|
||
| it(`should call onDateChanged for first day of current week when changing to current week`, () => { |
There was a problem hiding this comment.
Not sure I understand this test... you pressing the right arrow, then the left arrow, and expect the date returned to be the first day of the current week, when the initial date was not the first day of the week. Right?
There was a problem hiding this comment.
yes, when I initially wrote the test I remembered we returned to today when we scrolled to this week, but after we talked I understood this was not the expected behavior and changed to the correct behavior
Inbal-Tish
reviewed
Nov 13, 2022
…dd-integration-tests-expandable-calendar
Inbal-Tish
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.