CalendarList - fix staticHeader moves month out of range #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
May 28, 2023
Comment on lines
47
to
48
| pastScrollRange={RANGE} | ||
| futureScrollRange={RANGE} | ||
| pastScrollRange={0} | ||
| futureScrollRange={12} |
There was a problem hiding this comment.
Did u leave this on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow press should stop passing months in the static header when getting to the end of the past/future scroll range.
To test: in the horizontal CalendarList screen change the
past/futureScrollRangeprop to 0 or a small number and press the arrows to move btw months - when you get to the edges you can see the months in the header changing but the calendar is off - the months should not change at all. This PR fix this bug.