Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for refreshControl in the infiniteAgendaList.tsx #2283

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

yakirza17
Copy link
Contributor

No description provided.

@@ -46,7 +46,8 @@ const InfiniteAgendaList = (props: AgendaListProps) => {
infiniteListProps,
renderItem,
onEndReached,
onEndReachedThreshold
onEndReachedThreshold,
refreshControl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'refreshControl' prop is not declared anywhere. We can either add it to the component's props (extend AgendaListProps) or add the InfiniteListProps' scrollViewProps to the component's props and spread it before the overrides

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is declare here: AgendaListProps extends SectionListProps in the SectionListProps part

@Inbal-Tish Inbal-Tish merged commit 62892b4 into master Jul 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants