feat(timeline): add testId to timeline #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Dec 11, 2023
src/timeline-list/index.tsx
Outdated
| @@ -142,7 +144,7 @@ const TimelineList = (props: TimelineListProps) => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <Timeline {..._timelineProps}/> | |||
| <Timeline {..._timelineProps} testID={testID}/> | |||
There was a problem hiding this comment.
Shouldn't be better to pass the testID to the Timeline here as well (i.e. ${testID}.timeline)? If the user uses the Timeline component without the TimelineList they will pass it directly...
|
@yakirza17 Why did you remove the change in TimelineList? |
|
@Inbal-Tish It will passed as part of _timelineProps |
You only need it on the Timeline component? You don't need another testID on the TimelineList component? |
|
@Inbal-Tish no, the playable part is the scrollView inside the timeline, and the calendar component |
Inbal-Tish
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.