Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code reader integrated within camera-kit #60

Closed
gran33 opened this issue Aug 5, 2017 · 17 comments
Closed

QR Code reader integrated within camera-kit #60

gran33 opened this issue Aug 5, 2017 · 17 comments
Assignees
Labels

Comments

@gran33
Copy link
Contributor

gran33 commented Aug 5, 2017

Hi all,

How relevant is to support QR Code in this package?
Plz vote by add 👍 to this issue.

Thanks in advance.

@gran33 gran33 self-assigned this Aug 5, 2017
@lukaschleba
Copy link

At least some images, or gifs of complete work. Thanks

@gran33
Copy link
Contributor Author

gran33 commented Aug 22, 2017

@lukaschleba 🙂
I'm still try to understand if this feature is needed.

@lukaschleba
Copy link

I think it's not needed feature.

@gran33
Copy link
Contributor Author

gran33 commented Aug 22, 2017

Let's give the community to decide 👨‍💻

@jqn
Copy link

jqn commented Sep 8, 2017

I think it would be a great feature and a big plus if the android version uses zbar instead of zxing

@gran33
Copy link
Contributor Author

gran33 commented Sep 14, 2017

Hi all, and thanks for the support.

I started to work on this feature today, you can see the process in qrcode branch.

The API will be as follow:
If the prop onReadQRCode provided to CameraKitCameraScreen or to CameraKitCamera the function will be called each time the native will detect QR code, with relevant data (will be written in the docs).

The camera view/screen won't freeze or stop when QR is been detected and if you would like do something after QR code detected it's your responsibility (like open a browser, etc)

What do you think?
Are there any edge cases I've missed?

@josedevb
Copy link

@gran33
How long do you think it can be ready?

@gran33
Copy link
Contributor Author

gran33 commented Sep 16, 2017

@jozekcore I don't want to promise, but I'll do me best.

@tony1223
Copy link

Users need this feature.

@gran33
Copy link
Contributor Author

gran33 commented Sep 26, 2017

Guys, happy to announce that the QR code reading in now part of the camera (iOS only), just add onReadQRCode={(event) => console.log(event.nativeEvent.qrcodeStringValue)}
to CameraKitCamera or CameraKitCameraScreen components, and have some fum with the QR codes 🍻

@gran33 gran33 closed this as completed Sep 26, 2017
@loopingz
Copy link

Thank you but without the Android counterpart i wont be able to switch from react-native-camera

@cesargdm
Copy link

Just for the QRCode Scanning I was searching for a new package other than react-native-camera, hope comes to Android soon

@eltanno
Copy link

eltanno commented Dec 19, 2017

Eager to see android support added

@tokict
Copy link

tokict commented Jan 22, 2018

Now I should use 2 libs to do one thing depending on platform?

@steffenmllr
Copy link

@gran33 I was trying the onReadQRCode in the latest version and it does not get triggered - does it work in the current version ?

@dlucidone
Copy link

@gran33 The QRcode is not invoking? Is it working on ios?

@Sterlingryan
Copy link

So QRCode scanning is not supported on Android as of yet ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests