Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] LargeTitle is broken #6337

Closed
cesarm16 opened this issue Jun 25, 2020 · 4 comments · Fixed by #6489
Closed

[iOS] LargeTitle is broken #6337

cesarm16 opened this issue Jun 25, 2020 · 4 comments · Fixed by #6489

Comments

@cesarm16
Copy link

cesarm16 commented Jun 25, 2020

Issue Description

It's not possible to apply styles to largeTitle

Steps to Reproduce / Code Snippets / Screenshots

You can reproduce it in the playground app, try to apply tobBar styles in to SearchScreen largeTitle.

out

styles applied:

static options() {
    return {
      topBar: {
        noBorder: true, // it doesn't work 
        title: {
          text: "Search2",
          color: "green",  // it doesn't work 
        },
        largeTitle: {
          visible: true,
          color: "red",  // it doesn't work 
        },
        searchBar: true,
        background: {
          translucent: true,
        },
        searchBarPlaceholder: "Start Typing",
        hideNavBarOnFocusSearchBar: false,
      },
    };
}

you can see noBorder works only when largeTitle is not visible
fontFamily it doesn't work either

Environment

  • React Native Navigation version: 6.8.0
  • React Native version: 0.62.2
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Iphone 11 Pro (13.5) Simulator
@bennettk
Copy link
Contributor

ha, I came here to report exactly this. looks like it's iOS 13+ as it's working fine for me on iOS 12.

here's the same screen on iOS 13.5 vs 12.2, with the following options:

MoreView.options = {
  topBar: {
    title: {
      text: 'More',
    },
    largeTitle: {
      visible: true,
      fontSize: 36,
      fontFamily: 'Futura PT Heavy',
    }
  }
}

more

@axxag
Copy link

axxag commented Jul 3, 2020

I was able to track this down to the following PR:

#6027

If I revert to RNN v6.1.2 (before the PR was merged), or manually revert the PR, the issue disappears.

@guyca guyca added this to Selected for Development in React Native Navigation Jul 7, 2020
React Native Navigation automation moved this from Selected for Development to Done Aug 20, 2020
guyca pushed a commit that referenced this issue Aug 20, 2020
On iOS 13, title attributes should be applied on `scrollEdgeAppearance` as it applied on `standardAppearance`.

Closes #6337
@cesarm16
Copy link
Author

Thanks for solving many of the bugs in 6.12.1, really really appreciated, but noborder is still faulty.

@guyca
Copy link
Collaborator

guyca commented Aug 25, 2020

Hey @cesarm16
We'd love to look into that - can you please open another issue with the description? Please provide as much information as you can provide, gifs and code snippets would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

6 participants