Don't ask for overlay permissions, fix displaying errors on splashscreen. RN >= 0.52

[krystofcelba]

1. Don't ask for overlay permissions on RN >= 0.52 as it is not needed according to this commit.
2. Fix that redbox with error don't get displayed if there isn't yet any react activity, instead use the SplashActivity.

[yershalom]

Can one of the admins verify this patch?

[sonnysantino]

I can confirm that this patch fixes the dev menu overlay on Android 8

[Crash--]

Thank you for this fix @krystofcelba ! Works well :)

[dannysood]

Any update on this?

[maxlavax]

Any updates? +1
I'm facing this issue as well.

[zedtux]

Any updates on this please ?

[91ranjan]

How can I pull your fix for now? I am stuck on this.

[sampettersson]

@91ranjan A bit hacky but we added this to our postinstall:

git apply < android/patches/react-native-navigation.patch --directory=$PWD/node_modules/react-native-navigation --unsafe-paths || true

And just get the patch from here https://github.com/wix/react-native-navigation/pull/2801.patch

[91ranjan]

@Iamsamwhoami Thanks for the response. This fixed the issue for the red screen to appear. But still, there is an issue with "react-native-gesture-handler" which is where I came from.

Since for react-native-navigation, I have to extend SplashActivity. The function in gesture library that we have to override doesn't work.

This is specified in 'https://kmagiera.github.io/react-native-gesture-handler/docs/getting-started.html'

@Override protected ReactActivityDelegate createReactActivityDelegate()

Some error like
ERROR: Overriding a function not declared in the superclass.

Please let me know how can I resolve this issue.

I have raised the concern with react-native-gesture-handler as well:-

software-mansion/react-native-gesture-handler#128

UPDATE
As per the react-native-gesture team since the splash activity does not extends ReactActivity the override cannot happen.

Is there a work around for this?

[jpate148]

@guyca Any update?

[mths0x5f]

instered in not asking overlay api for v2 aswell

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zedtux]

Let us alone stupid bot !

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zedtux]

Any update here before this stupid bot close the PR?

[guyca]

Will address this soon.

[jneuendorf]

@Iamsamwhoami I can't get your command to work. I've googled and tried everything but when I run the command with --verbose it says Skipped patch ... for all 3 files.
I've also tried the --no-index option because I thought the commit hashes might differ...

Only patch -p1 --directory=$PWD/node_modules/react-native-navigation < android/patches/react-native-navigation.patch worked for me so far.