Fix/rootview bounds iphone x #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/deprecated/platformSpecificDeprecated.android.js
Conflicts: src/deprecated/platformSpecificDeprecated.android.js
…avigation * 'master' of https://github.com/3sidedcube/react-native-navigation: Fixed issue with rightButtons getting ignored in preference for empty Screen buttons
Merge wix/react-native-navigation master into 3sidedcube/react-native-navigation master
a scrollable view to a non-scrollable view the root view's bounds would be incorrect
Merge wix/master into ours
|
@yogevbd Can this be reviewed please.. Thanks! :) |
|
I updated our project to use this version and our custom NavBar just went away. I pulled the example project and I only see the Navigator Buttons (right and left). From the code I can see that there is a button in the center of the navbar but it's nowhere to be seen in the app. Can you confirm this issue @simonmitchell @yogevbd
|
pmogollons
added a commit
to pmogollons/react-native-navigation
that referenced
this pull request
Jul 10, 2018
This reverts commit 9d4eea8.
guyca
pushed a commit
that referenced
this pull request
Jul 12, 2018
|
@yogevbd @guyca I have tested this using the latest code on this branch and it seems to work fine in the example project. I think the problem was that I created the merge request prematurely and then shortly after fixed some issues I'd caused, but the PR had already been merged by this point (Impressively quick work from you guys!) |
reimertz
pushed a commit
to mavencook/react-native-navigation
that referenced
this pull request
Sep 14, 2018
* Fixed issue with rightButtons getting ignored in preference for empty Screen buttons * Fixes an issue where on an iPhone X when showing the tab bar on pop from a scrollable view to a non-scrollable view the root view's bounds would be incorrect
reimertz
pushed a commit
to mavencook/react-native-navigation
that referenced
this pull request
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
self.viewon aUIViewControllershould not be done in this way, if at all... It can lead to unexpected behaviour, which has been shown in the recent issues submitted where UI glitches were seen on an iPhone X:#2849
#3250
which this pull request fixes!