Fix autolink script

[jinshin1013]

This PR fixes the autolink script including:

• Specifying the minSdkVersion for Android. Closes RN CLI Autolinking error #5983.
• Removing the RNN Pod added by the react-native link script.

@guyca I've assumed the minSdkVersion will be 19 unless user specified higher. I've got the version from the doc, should this be updated to something higher?

[guyca]

Hey @jinshin1013 Thanks for the PR!

• minSdk should be 19 as we don't support 18 and below. At Wix, our minSdk is 21 but it really depends on your needs. If you don't test your app against older devices and can't guarantee it performs as expected on these old devices then you better increase your minSdk to 21.

• Can you please explain why the change to podfile is needed? Is it to remove the pod definition in case users added it by following previous installation instructions?

[jinshin1013]

@guyca Thanks for catching the regex issue, I'm still trying to get myself used to it 😓

minSdk should be 19 as we don't support 18 and below.

Makes sense for minSdkVersion to be at least 19 and I also reckon most people would use 21 anyway.

Can you please explain why the change to podfile is needed?

I've found that whenever I run react-native link react-native-navigation it adds the pod definition for react-native-navigation. I'm using @react-native-community/cli@3.2.0 so I don't think it's the cli problem. You should be able to reproduce this problem with fresh react-native project. Also as you mentioned I reckon it'd be good for the existing users who followed the previous installation step anyway.

[guyca]

I've found that whenever I run react-native link react-native-navigation it adds the pod definition for react-native-navigation.

Isn't this desired? I thought react-native link adds all native dependencies to the podfile.

[jinshin1013]

Isn't this desired? I thought react-native link adds all native dependencies to the podfile.

That is true for react-native version below 0.60 as they do not support autolinking. But I believe tools should assume users are on the "new" react-native and add somewhere in the documentation for the legacy linking (adding Pod definition). Thoughts?