V7 #6422
Merged
V7 #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change: The reason behind that is, there are no pros in handling js location in react-native-navigation (this feels outside the scope of that library) and there are definitely cons of doing so. For starters, it forces us to use [BridgeManager as the responder of RCTBridgeDelegate](https://github.com/wix/react-native-navigation/blob/master/lib/ios/RNNBridgeManager.m#L45), which used to be fine, but..: with TurboModules there's now a need of responding to other protocols, such as: - the `RCTCxxBridgeDelegate` ([see here](https://github.com/facebook/react-native/blob/e549f6984e2125969fd11a5b8f4e2df866ac0495/React/CxxBridge/RCTCxxBridge.mm#L368)), - and the `RCTTurboModuleManagerDelegate` all of which are declared via the `RCTBridge` initialisation (which happened and still happens in `RNNBridgeManager`) Changing the responder of `RCTBridgeDelegate` from `RNNBridgeManager` to the actual `AppDelegate` of the app being built, allows the end user to integrate with TurboModules and customise their code as much as they want, plus it provides a future proof way of making sure RNN doesn't break react-native additions especially since the turbo modules api is fairly new and likely to change.
This PR introduces Coroutines in favor of traditional callbacks in SET. Coroutines promote more idiomatic asynchronous code similar to javascripts async await.
RNN should be agnostic of state management solutions. Redux can be used with the regular registerComponent method:
```js
const myStore = createStore();
Navigation.registerComponent(
'MyScreen',
() => (props) => (
<Provider store={myStore}>
<MyScreen {...props} />
</Provider>
),
() => MyScreen
);
```
When updating FAB options with mergeOptions, id must be passed as well.
* Resolve `Navigation.dismissModal()` with topmost parent `componentId`. * Resolve `ModalDismissedListener` event with topmost parent `componentId`. * Remove `componentName` from `ModalDismissedListener` event.
* Replace drawBehind implementation to use constraints - Until now we used `edgesForExtendedLayout` for drawing behind the `topBar` and `bottomTabs`. This is no longer recommended by Apple and the new approach is to use constraints and `safeAreaLayoutGuide`.. * Officially remove iOS 10 support.
* Resolve `setRoot` with root `componentId` * Resolve `push` with pushed screen `componentId` * Remove `params` from commandCompletion events
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.