Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard bottom insets removing bottom tabs margin #7441

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

swabbass
Copy link
Contributor

@swabbass swabbass commented Feb 7, 2022

Issue:

When Bottom tabs are visible a margin is added on top of the keyboard when it was opened.
The margin is a bottom inset set to component due to bottom tabs height, which always will push the component up by bottom tabs height pixels.

Fix:

  • Determine bottom insets when bottom tabs are hidden or visible.
  • Subtract the component bottom inset from new insets once the keyboard is opened.

@yogevbd yogevbd merged commit f3ac5c5 into master Feb 8, 2022
@yogevbd yogevbd deleted the keyboard_insets_compat branch February 8, 2022 09:26
yogevbd added a commit that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
React Native Navigation
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants