Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Dictionary into RNNDictionary #7853

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

lampapos
Copy link
Contributor

Dictionary interface might create a name collision with Swift Dictionary. Such collision might lead to issues like this:

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Unacceptable type of value for attribute: property = "data"; desired type = Dictionary; given type = _TtGCs26_SwiftDeferredNSDictionarySSSS_$; value = {
    "app_type" = MEP;
    "application_bundle_id" = "[.../)";
    "application_installer_id" = "com.apple.dt.Xcode";
    "application_name" = Xxx;
    "application_version" = "999.999.999";
    "client_id" = "6033B0D3-8960-4C89-9B5F-0EF0A9FDA30F";
    country = UA;
    "device_platform" = "iPhone16,1|iOS|17.2";
    "external_app_id" = "b8186bd9-fcba-b77a-11e3-1c0d2e5a3501";
    "mep_analytics_sdk_version" = "1.1.1";
}.'

Copy link
Collaborator

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥳
In a different PR, I plan to refactor (especially rename) other files that could lead to similar conflicts, aiming to prevent further issues of this special kind 🤯
Well done @lampapos!

@asafkorem asafkorem merged commit 2b309d4 into master Feb 21, 2024
6 of 7 checks passed
@asafkorem asafkorem deleted the fix/swift_dictionary branch February 21, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants